Fix CI ARM64 compatibility by replacing arduino/setup-protoc@v1 with cross-platform protoc installation #60 #344
+84
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7908837174
changed the title
7908837174
force-pushed
the
fix-ci-arm64-compatibility
branch
2 times, most recently
from
e4f5f8d to
75ae307
Compare
Author
|
Hi @yogeshbdeshpande @thomas-fossati @cowbon @deeglaze @iolivergithub @jraman567 Sir: PR #344 fixes CI ARM64 compatibility by replacing arduino/setup-protoc@v1 with a cross-platform protoc installer (adds ARM64 support, docs and tests) — please review and approve to unblock merging. |
setrofim
reviewed
Oct 1, 2025
Collaborator
setrofim
left a comment
setrofim
left a comment
There was a problem hiding this comment.
- Please update commit messages to use conventional commits format.
- I'm unclear on what the
*.mdfiles are doing? They appear to contain metadata specific to this pull -- not something that should be part of the code.
…llation The arduino/setup-protoc@v1 action contained x86_64-specific binaries that failed on ARM64 systems (Apple M1/M2, ARM64 Linux) when using the 'act' tool for local CI testing. Changes: - Replace arduino/setup-protoc@v1 with cross-platform shell script in all workflows - Auto-detect architecture (x86_64, aarch64, arm64) - Download appropriate protoc binary from official GitHub releases - Install to /usr/local/bin/protoc with proper includes - Upgrade to protoc v25.1 (latest stable) - Add comprehensive error handling and validation Files updated: - .github/workflows/ci-go-cover.yml - .github/workflows/ci.yml - .github/workflows/linters.yml - .github/workflows/time-package.yml This enables local CI testing on ARM64 systems while maintaining full backward compatibility with existing x86_64 runners. Fixes veraison#60 Signed-off-by: Kallal Mukherjee <[email protected]>
7908837174
force-pushed
the
fix-ci-arm64-compatibility
branch
from
75ae307 to
3029d49
Compare
Author
|
Kindly requesting re-review from SIR @setrofim @yogeshbdeshpande @mcdonc @thomas-fossati for PR #344 |
Author
|
Requesting merge for PR #344: ARM64 CI fix with cross-platform protoc installer, approved by @setrofim — kindly requesting workflow approval from @yogeshbdeshpande @mcdonc @thomas-fossati @cowbon @deeglaze @iolivergithub @jraman567 to unblock. |
Author
This was referenced Oct 2, 2025
Merged
Author
|
Requesting re-review and approval for PR #344 from sir @yogeshbdeshpande ,sir @thomas-fossati , sir @cowbon .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed Description
This PR resolves the ARM64 compatibility issue in GitHub Actions workflows that prevented local CI testing on Apple M1/M2 Macs and ARM64 systems using the
acttool.Problem
arduino/setup-protoc@v1action contained x86_64-specific binaries in itsnode_modules/@actions/tool-cache/scripts/externals/directoryqemu-x86_64: Could not open '/lib64/ld-linux-x86-64.so.2': No such file or directorySolution
Replaced the problematic action with a robust shell script that:
Auto-detects system architecture:
x86_64→ Downloadsprotoc-25.1-linux-x86_64.zipaarch64/arm64→ Downloadsprotoc-25.1-linux-aarch_64.zip** Direct installation from official releases**:
https://github.com/protocolbuffers/protobuf/releases//usr/local/bin/protocwith proper includesprotoc --version** Upgraded to latest stable protoc v25.1**
Files Changed
.github/workflows/ci-go-cover.yml.github/workflows/ci.yml.github/workflows/linters.yml.github/workflows/time-package.yml.github/workflows/PROTOC_FIX.mdTesting